Skip to content

Commit

Permalink
Code Review Changes
Browse files Browse the repository at this point in the history
  • Loading branch information
verdan committed Aug 18, 2020
1 parent 7b6c893 commit e87a0a0
Showing 1 changed file with 5 additions and 8 deletions.
13 changes: 5 additions & 8 deletions metadata_service/proxy/atlas_proxy.py
Original file line number Diff line number Diff line change
Expand Up @@ -377,23 +377,22 @@ def _get_reports(self, guids: List[str]) -> List[ResourceReport]:

return parsed_reports

def _get_owners(self, data_owner: list, fallback_owner: str) -> List[User]:
data_owners = list()
def _get_owners(self, data_owners: list, fallback_owner: str) -> List[User]:
owners_detail = list()
active_owners = filter(lambda item:
item['entityStatus'] == Status.ACTIVE and
item['relationshipStatus'] == Status.ACTIVE,
data_owner)
data_owners)

for owner in active_owners:
owner_qn = owner['displayText']
# noinspection PyArgumentList
owner_data = self.user_detail_method(owner_qn) or {
'email': owner_qn,
'user_id': owner_qn
}
data_owners.append(User(**owner_data))
owners_detail.append(User(**owner_data))

return data_owners or [User(email=fallback_owner, user_id=fallback_owner)]
return owners_detail or [User(email=fallback_owner, user_id=fallback_owner)]

def get_user(self, *, id: str) -> Union[UserEntity, None]:
pass
Expand Down Expand Up @@ -490,7 +489,6 @@ def add_owner(self, *, table_uri: str, owner: str) -> None:
:param owner: Email address of the owner
:return: None, as it simply adds the owner.
"""
# noinspection PyArgumentList
if not (self.user_detail_method(owner) or owner):
raise NotFoundException(f'User "{owner}" does not exist.')

Expand Down Expand Up @@ -821,7 +819,6 @@ def _get_readers(self, qualified_name: str, top: Optional[int] = 15) -> List[Rea

for read_entity in read_entities:
reader_qn = read_entity.relationshipAttributes['user']['displayText']
# noinspection PyArgumentList
reader_details = self.user_detail_method(reader_qn) or {
'email': reader_qn,
'user_id': reader_qn
Expand Down

0 comments on commit e87a0a0

Please sign in to comment.