Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix docker push #190

Merged
merged 7 commits into from
Sep 2, 2020
Merged

chore: fix docker push #190

merged 7 commits into from
Sep 2, 2020

Conversation

feng-tao
Copy link
Member

@feng-tao feng-tao commented Sep 2, 2020

Summary of Changes

fix docker push typo

Tests

What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line

Documentation

What documentation did you add or modify and why? Add any relevant links then remove this line

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

@feng-tao feng-tao requested review from Golodhros and verdan September 2, 2020 04:14
Signed-off-by: feng-tao <[email protected]>
@feng-tao feng-tao force-pushed the tfeng_fix_docker_push branch from 21d073b to 00c100f Compare September 2, 2020 04:14
Signed-off-by: feng-tao <[email protected]>
Signed-off-by: feng-tao <[email protected]>
Signed-off-by: feng-tao <[email protected]>
Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@feng-tao feng-tao merged commit c2eb989 into master Sep 2, 2020
@feng-tao feng-tao deleted the tfeng_fix_docker_push branch September 2, 2020 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants