feat: Improved readers fetching in Atlas proxy

[mgorsk1]

Signed-off-by: mgorsk1 [email protected]

Summary of Changes

This PR introduces change in strategy for fetching frequent users for a table. Instead of using basic search, which proved to be unreliable when dealing with special characters (like dots) in qualifiedName prefix search, we created a new kind of relationship in amundsen-atlas-types and are relying on it being connected to a table.

Tests

Adjusted existing tests.

Documentation

Changed minimum version of amundsen-atlas-types

CheckList

Make sure you have checked all steps below to ensure a timely review.

• PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.
• PR includes a summary of changes.
• PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
• In case of new functionality, my PR adds documentation that describes how to use it.
  • All the public functions and the classes in the PR contain docstrings that explain what it does
• PR passes make test

[feng-tao]

cc @verdan

[codecov-io]

Codecov Report

Merging #218 into master will increase coverage by 2.59%.
The diff coverage is 70.40%.

@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
+ Coverage   74.10%   76.69%   +2.59%     
==========================================
  Files          25       27       +2     
  Lines        1255     1326      +71     
  Branches      136      159      +23     
==========================================
+ Hits          930     1017      +87     
+ Misses        297      265      -32     
- Partials       28       44      +16     

Impacted Files	Coverage Δ
metadata_service/api/user.py	100.00% <ø> (ø)
metadata_service/proxy/shared.py	28.57% <28.57%> (ø)
metadata_service/proxy/neo4j_proxy.py	71.46% <55.73%> (-3.54%)	⬇️
metadata_service/api/badge.py	61.29% <61.29%> (ø)
metadata_service/proxy/base_proxy.py	67.08% <72.72%> (-0.06%)	⬇️
metadata_service/proxy/atlas_proxy.py	80.34% <79.19%> (-3.97%)	⬇️
metadata_service/__init__.py	76.47% <100.00%> (ø)
metadata_service/api/dashboard.py	81.81% <100.00%> (+8.48%)	⬆️
metadata_service/api/table.py	100.00% <100.00%> (ø)
metadata_service/api/tag.py	92.85% <100.00%> (ø)
... and 9 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc3768f...53e18be. Read the comment docs.

[verdan]

@mgorsk1 since we are on to this, can you please specify the min version of Atlas required for the Amundsen.

[mgorsk1]

https://github.com/amundsen-io/amundsen/blob/master/docs/faq.md it's available here. I will raise separate MR to update amundsen-atlas-types there