Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reapply previous fix #245

Merged
merged 1 commit into from
Jan 6, 2021
Merged

fix: reapply previous fix #245

merged 1 commit into from
Jan 6, 2021

Conversation

feng-tao
Copy link
Member

@feng-tao feng-tao commented Jan 6, 2021

Signed-off-by: feng-tao [email protected]

Summary of Changes

When #233 is rebased, it reverted previous fix (https://github.com/amundsen-io/amundsenmetadatalibrary/pull/239/files). This pr reapplies the fix.

Tests

What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line

Documentation

What documentation did you add or modify and why? Add any relevant links then remove this line

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

@feng-tao
Copy link
Member Author

feng-tao commented Jan 6, 2021

cc @joshthoward

@feng-tao feng-tao requested a review from Golodhros January 6, 2021 06:27
@feng-tao
Copy link
Member Author

feng-tao commented Jan 6, 2021

cc @tianruzhou-db who did the original fix as well

@codecov-io
Copy link

Codecov Report

Merging #245 (b80789f) into master (2752492) will increase coverage by 2.61%.
The diff coverage is 71.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
+ Coverage   74.10%   76.72%   +2.61%     
==========================================
  Files          25       27       +2     
  Lines        1255     1336      +81     
  Branches      136      161      +25     
==========================================
+ Hits          930     1025      +95     
+ Misses        297      266      -31     
- Partials       28       45      +17     
Impacted Files Coverage Δ
metadata_service/api/popular_tables.py 100.00% <ø> (ø)
metadata_service/api/user.py 100.00% <ø> (ø)
metadata_service/proxy/shared.py 28.57% <28.57%> (ø)
metadata_service/api/badge.py 61.29% <61.29%> (ø)
metadata_service/proxy/neo4j_proxy.py 71.65% <61.33%> (-3.35%) ⬇️
metadata_service/proxy/base_proxy.py 67.08% <75.00%> (-0.06%) ⬇️
metadata_service/proxy/atlas_proxy.py 80.34% <79.19%> (-3.97%) ⬇️
metadata_service/__init__.py 76.47% <100.00%> (ø)
metadata_service/api/dashboard.py 81.81% <100.00%> (+8.48%) ⬆️
metadata_service/api/table.py 100.00% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d045efa...b80789f. Read the comment docs.

Copy link
Contributor

@allisonsuarez allisonsuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@feng-tao feng-tao merged commit c7dc172 into master Jan 6, 2021
@feng-tao feng-tao deleted the tfeng_reapply_fix branch January 6, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants