Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc fix: Docker pull new official image #35

Merged
merged 1 commit into from
Apr 30, 2019

Conversation

jornh
Copy link
Contributor

@jornh jornh commented Apr 30, 2019

Make sure you have checked all steps below.

Title

  • My PR Title addresses the issue accurately and concisely.
    • Example: "Updates the version of Flask to v1.0.2"
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Closes #20 - the old readme.md didn’t include full docker name including user/

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Just documentation fix

Commits

  • I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

Just documentation fix

Code Quality & Coverage

  • Passes make test

@jornh jornh changed the title Docker pull new official image Doc fix: Docker pull new official image Apr 30, 2019
@feng-tao
Copy link
Member

thanks @jornh

@feng-tao feng-tao merged commit 235bf5b into amundsen-io:master Apr 30, 2019
@jornh jornh deleted the patch-1 branch April 30, 2019 22:53
jornh added a commit to jornh/amundsensearchlibrary that referenced this pull request Apr 30, 2019
feng-tao pushed a commit to amundsen-io/amundsensearchlibrary that referenced this pull request Apr 30, 2019
* Doc fix: Docker pull the official image

Similar to metadata service fix amundsen-io/amundsenmetadatalibrary#35

* Typo fix
dorianj pushed a commit to dorianj/amundsen that referenced this pull request Apr 25, 2021
* Doc fix: Docker pull the official image

Similar to metadata service fix amundsen-io/amundsenmetadatalibrary#35

* Typo fix
feng-tao pushed a commit to amundsen-io/amundsen that referenced this pull request May 7, 2021
* Doc fix: Docker pull the official image

Similar to metadata service fix amundsen-io/amundsenmetadatalibrary#35

* Typo fix
zacr pushed a commit to SaltIO/amundsen that referenced this pull request May 13, 2022
* Doc fix: Docker pull the official image

Similar to metadata service fix amundsen-io/amundsenmetadatalibrary#35

* Typo fix
hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this pull request Jun 30, 2022
* Doc fix: Docker pull the official image

Similar to metadata service fix amundsen-io/amundsenmetadatalibrary#35

* Typo fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker pull amundsen-metadata : repository does not exist
2 participants