-
Notifications
You must be signed in to change notification settings - Fork 31
Conversation
This was a bit premature, once #184 is merged in the tests should pass |
Codecov Report
@@ Coverage Diff @@
## develop #185 +/- ##
===========================================
- Coverage 88.15% 88.09% -0.06%
===========================================
Files 80 80
Lines 4085 4108 +23
Branches 693 693
===========================================
+ Hits 3601 3619 +18
- Misses 310 313 +3
- Partials 174 176 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix Mark.
Is there a reason you only add this for GPRegression and not for SparseGP or SVIGP?
Laziness mainly. If you don't want to do anything more general (especially for copying kernels?) I can add it to the other GP modules |
Now added fixes + tests for all GP modules |
This fixes #183 (but maybe you want to copy kernels in a different way as discussed yesterday). It also fixes a few other issues with cloning this specific GP module and adds tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.