fix(cleanfile): add file check and log for non-existent file (#277)

amzn · May 28, 2019 · 6375133 · 6375133
1 parent 9a40407
commit 6375133
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 0 deletions.
diff --git a/.gitignore b/.gitignore
@@ -33,6 +33,9 @@ jspm_packages
 # Optional npm cache directory
 .npm
 
+# yarn
+yarn.lock
+
 # Optional REPL history
 .node_repl_history
 

diff --git a/__tests__/cleanFile.test.js b/__tests__/cleanFile.test.js
@@ -35,4 +35,10 @@ describe('cleanFile', () => {
     expect(helpers.fileDoesNotExist('./__tests__/__output/test.txt')).toBeTruthy();
   });
 
+  describe('if a file does not exist', () => {
+    it('should not throw', () => {
+      expect(() => cleanFile('non-existent.txt', format, { buildPath: '__tests__/__output/' }, {})).not.toThrow();
+    })
+  })
+
 });
diff --git a/lib/cleanFile.js b/lib/cleanFile.js
@@ -39,6 +39,11 @@ function cleanFile(destination, format, platform, dictionary, filter) {
 
   var dirname = path.dirname(destination);
 
+  if (!fs.existsSync(destination)) {
+    console.log(chalk.bold.red('!') + ' ' + destination + ', does not exist');
+    return;
+  }
+
   fs.unlinkSync(destination);
   console.log(chalk.bold.red('-') + ' ' + destination);
 }