-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multibrand example still uses templates rather than formats #226
Comments
Sorry I saw why you have used that style of quotation marks there, the script breaks if using traditional quotes. Ignore the second bit of my issue :) |
@custa1200 I'll have a look at the example (I've done it, I don't remember if there were good reasons to still use templates in this case). Regarding the quotes, they are template literals, they are intended :) |
Well thats my thing learnt for the day :) |
@custa1200 I have checked, and the example with the multi-brand example is correct, the "template" is still a valid declaration in the config (these are the standard templates). what is deprecated is the "registerTemplate" method, which actually was still used in another example, so I have updated that one in #232. Thank you for raising the issue. |
To add a bit more context, when we began the deprecation path of templates, we copied all built-in templates to formats of the same name. Until we full remove templates/registerTemplate from the codebase you should be able to call them either as formats or templates. If you call it as a template it will show a warning message and how to migrate though! |
Fixed in v2.7.0 |
In the build.js file the android and iOS groups still use the old template formats. It also uses a mix of quotation marks as can be seen in the build path.
The text was updated successfully, but these errors were encountered: