Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove registerTemplate from examples #232

Merged
merged 5 commits into from
Jan 29, 2019
Merged

Remove registerTemplate from examples #232

merged 5 commits into from
Jan 29, 2019

Conversation

didoo
Copy link
Contributor

@didoo didoo commented Jan 19, 2019

Issue #, if available: #226

Description of changes: I have updated the "custom-templates" example in the examples/advanced folder:

  • removed any reference to the registerTemplate method and converted everything to registerFormat, keeping the different template files (for different engines) so the users can have a good overview of the possible alternatives and possibilities
  • renamed the folder from "custom-templates" to "custom-formats-with-templates"
  • updated the documentation accordingly

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Member

@dbanksdesign dbanksdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is just 1 change, but other than that good work!

examples/advanced/custom-formats-with-templates/README.md Outdated Show resolved Hide resolved
Copy link
Member

@dbanksdesign dbanksdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@chazzmoney
Copy link
Collaborator

LGTM!

@chazzmoney chazzmoney merged commit 5a5a260 into amzn:develop Jan 29, 2019
dbanksdesign added a commit that referenced this pull request Feb 5, 2019
* feat: add registerFilter method (#233)
* doc: remove registerTemplate from examples (#232)
* feat: add node example (#228)
* feat: making include accept an array of globs, like source does (#227)
* fix: the naming for Sass/Scss in documentation, tests, formats, fixes #213 (#222)
* fix: handle showFileHeader option in androids formats templates, fixes #237
 (#243)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants