Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: absolute paths in Node env #1134

Merged
merged 1 commit into from
Mar 26, 2024
Merged

fix: absolute paths in Node env #1134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tricky-snakes-appear.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'style-dictionary': patch
---

Fix scenario of passing absolute paths in Node env, do not remove leading slash in absolute paths.
7 changes: 5 additions & 2 deletions lib/utils/combineJSON.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,11 @@ export default async function combineJSON(
files = files.concat(new_files);
}

// adjust for browser env glob results have leading slash
files = files.map((f) => f.replace(/^\//, ''));
if (typeof window === 'object') {
// adjust for browser env glob results have leading slash
// make sure we dont remove these in Node, that would break absolute paths!!
files = files.map((f) => f.replace(/^\//, ''));
}

for (let i = 0; i < files.length; i++) {
const filePath = files[i];
Expand Down
Loading