Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bypass the entrypoint mechanism #156

Merged
merged 2 commits into from
Mar 3, 2020
Merged

Bypass the entrypoint mechanism #156

merged 2 commits into from
Mar 3, 2020

Conversation

mcg1969
Copy link
Collaborator

@mcg1969 mcg1969 commented Mar 3, 2020

Fixes #155 for now

@mcg1969
Copy link
Collaborator Author

mcg1969 commented Mar 3, 2020

And while we're at it, address #154 as well

@mcg1969 mcg1969 merged commit 1b9e821 into anaconda:master Mar 3, 2020
Copy link

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Michael. This is exactly the same conclusion I had reached.

@@ -101,7 +101,11 @@ def install(enable=False, disable=False, status=None, prefix=None, path=None, ve
log.info("{}ing nb_conda_kernels...".format(ENDIS[enable][:-2].capitalize()))

is_enabled_entry = False
has_entrypoints = int(jc_version.split('.', 1)[0]) >= 6
# Disable the entry-point based mechanism. Most if this code will need

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Most if -> Most of

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility with Jupyter client 6
2 participants