Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable window correction in FFT plot #467

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Enable window correction in FFT plot #467

merged 2 commits into from
Dec 4, 2023

Conversation

cristina-suteu
Copy link
Contributor

Added check button to enable the window correction
check button is disabled by default
the check button state is passed as a member of the _fft_settings / _freq_spectrum_settings structures

@cristina-suteu
oscplot: enable/ disable window correction
9f25d66 
check button to enable window correction, disabled by default

Signed-off-by: Cristina Suteu <[email protected]>
mhennerich
mhennerich reviewed Nov 30, 2023
View reviewed changes
Copy link
Contributor

@mhennerich mhennerich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks
Two minor things:

  1. The window correction should be by default enabled
  2. I think we should grey out the button while in run mode, similar to the size and window type, since changing the state only takes into effect when you start/run.

@cristina-suteu
oscplot: win correction check fixes
b616905 
window correction enabled by default
check button becomes inactive when plot is running

Signed-off-by: Cristina Suteu <[email protected]>
@cristina-suteu
Copy link
Contributor Author

@mhennerich fixed in new commit

@cristina-suteu cristina-suteu merged commit 5c3fcaa into master Dec 4, 2023
10 checks passed
@cristina-suteu cristina-suteu deleted the window-correction branch December 4, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhennerich mhennerich mhennerich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cristina-suteu @mhennerich