Liiio master merge to dev + dynamic/scan rework #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcercuei
force-pushed
the
pcercuei/dev-rework-scan
branch
2 times, most recently
from
485687d to
cbf83dc
Compare
|
I'm not sure what's going on, it builds fine on Windows here. Looks like the CI doesn't even attempt to build the library, and jumps straight to building the C# bindings. |
rgetz
approved these changes
Feb 21, 2022
|
yeah, I dno't know why Windows doesn't build properly... -Robin |
pcercuei
force-pushed
the
pcercuei/dev-rework-scan
branch
6 times, most recently
from
f971a89 to
8632412
Compare
Instead of using the 'struct iio_module' as an opaque pointer directly to the underlying platform-specific type, make it a real object. This has the benefit of providing a better API: one function to create the iio_module, one to destroy it, and one function to get the iio_backend from the iio_module. The platform-specific functions are now called iio_dlopen, iio_dlclose, and iio_dlsym, so that the old function names can be reused by the new code. Signed-off-by: Paul Cercueil <[email protected]>
pcercuei
force-pushed
the
pcercuei/dev-rework-scan
branch
from
8632412 to
b3bda0d
Compare
Since the latest merge of libiio master it was possible to specify the list of backends to scan, but this only worked with the built-in backends. With this commit, when a requested backend is not built-in, it will be attempted to be loaded from the corresponding module. Additionally, since commit 163f9a5 ("scan: Fix default backends list containing disabled backends") we have a list of all the enabled backends, built-in or modules; so all of our installed modules will be scanned by default, and it makes no sense to call iio_dynamic_scan() anymore. Signed-off-by: Paul Cercueil <[email protected]>
pcercuei
force-pushed
the
pcercuei/dev-rework-scan
branch
from
b3bda0d to
2390a7e
Compare
|
Finally building under the CI. I'll merge it tomorrow if nothing else comes up before that. |
The iio_dynamic_scan() function and all its dependencies are not needed anymore, and can be safely dropped. Signed-off-by: Paul Cercueil <[email protected]>
pcercuei
force-pushed
the
pcercuei/dev-rework-scan
branch
from
2390a7e to
f8b7c61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the recent work done on the scan feature in the master branch (#791).
The merge commit rewrites a good part of the code, since the scan code had been updated heavily in the dev branch.
On top of the merge, two commits were added: