Fixes warning logged during Home Assistant start #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://developers.home-assistant.io/blog/2024/06/12/async_forward_entry_setups/ for more information. Fixes warnings like this: ``` 2024-06-18 20:06:22.690 WARNING (MainThread) [homeassistant.helpers.frame] Detected that custom integration 'fmi' calls async_forward_entry_setup for integration, fmi with title: Bodö and entry_id: 2bd0b11d9f9c95f134faab9e4ddb03e8, which is deprecated and will stop working in Home Assistant 2025.6, await async_forward_entry_setups instead at custom_components/fmi/__init__.py, line 72: hass.async_create_task(, please report it to the author of the 'fmi' custom integration ```
slovdahl
commented
Jun 18, 2024
| for component in PLATFORMS: | ||
| await hass.config_entries.async_forward_entry_unload(config_entry, component) | ||
| await hass.config_entries.async_unload_platforms(config_entry, PLATFORMS) |
There was a problem hiding this comment.
This doesn't fix any warning right now, but https://github.com/home-assistant/core/blob/9723b97f4bd42c850f5cb5fbf67ecdfc55769861/homeassistant/config_entries.py#L2175-L2182 says that async_unload_platforms is the preferred method nowadays.
|
Tested that it fixed the warning in my development instance. |
|
@cruwaller you maybe want to take a look when you have some time 🙂 |
|
Thanks a lot! |
|
@cruwaller Any chance we could get a release with this fix included? 🙇 |
|
Yeah, let's include #72 as well and I will trigger a release 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://developers.home-assistant.io/blog/2024/06/12/async_forward_entry_setups/ for more information.
Fixes warnings like this: