Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Build] fail silently on register git hook failure
`node scripts/register_git_hook` fails depending on the installed git version because it ends up calling `git rev-parse --git-common-dir`. Depending on the git version, `--git-common-dir` returns the literal string `--git-common-dir` when it is suppose to return $GIT_COMMON_DIR if set and $GIT_DIR if the previous is not set. Then it proceeds to try to install from a path that doesn't exist because it will use `--git-common-dir` in the path. The goal for this fix is to bypass hard failures in 1.x since I do not believe it is appropriate to fail building something due to git. But I do not want to just remove adding the pre-commit git hook if people are already used to it being installed while bootstrapping. Here, I propose the removal of git hooks on bootstrap in a 2+ version of Dashboards: opensearch-project#851 Issue resolved: opensearch-project#850 Signed-off-by: Kawika Avilla <[email protected]>
- Loading branch information