Restrict preferences page height #251

thanks @laurentmuller Signed-off-by: Andre Bossert <[email protected]>
anb0s · Mar 30, 2022 · c275d17 · c275d17
1 parent 62b6e95
commit c275d17
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 14 deletions.
diff --git a/plugin/src/de/anbos/eclipse/easyshell/plugin/preferences/CommandPage.java b/plugin/src/de/anbos/eclipse/easyshell/plugin/preferences/CommandPage.java
@@ -223,14 +223,11 @@ private void createTableViewer(Composite parent) {
         // contentProvider
         tableViewer.setInput(CommandDataStore.instance());
 
-        // Layout the viewer
-        GridData gridData = new GridData();
-        gridData.verticalAlignment = GridData.FILL;
+        // Layout the table viewer
+        GridData gridData = new GridData(GridData.FILL_BOTH);
+        gridData.heightHint = table.getItemHeight() * 20;
         gridData.horizontalSpan = 2;
-        gridData.grabExcessHorizontalSpace = true;
-        gridData.grabExcessVerticalSpace = true;
-        gridData.horizontalAlignment = GridData.FILL;
-        tableViewer.getControl().setLayoutData(gridData);
+        table.setLayoutData(gridData);
 
         tableViewer.addDoubleClickListener(new IDoubleClickListener() {
             @Override

diff --git a/plugin/src/de/anbos/eclipse/easyshell/plugin/preferences/MenuPage.java b/plugin/src/de/anbos/eclipse/easyshell/plugin/preferences/MenuPage.java
@@ -211,14 +211,11 @@ private void createTableViewer(Composite parent) {
         // contentProvider
         tableViewer.setInput(MenuDataStore.instance());
 
-        // Layout the viewer
-        GridData gridData = new GridData();
-        gridData.verticalAlignment = GridData.FILL;
+        // Layout the table viewer
+        GridData gridData = new GridData(GridData.FILL_BOTH);
+        gridData.heightHint = table.getItemHeight() * 20;
         gridData.horizontalSpan = 2;
-        gridData.grabExcessHorizontalSpace = true;
-        gridData.grabExcessVerticalSpace = true;
-        gridData.horizontalAlignment = GridData.FILL;
-        tableViewer.getControl().setLayoutData(gridData);
+        table.setLayoutData(gridData);
 
         tableViewer.addDoubleClickListener(new IDoubleClickListener() {
             @Override