feat: remove duplicated constraints #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Neate <[email protected]>
|
Thanks @jneate and sorry for the delay on this one. I think if you rebase you should get to a point where the tests hopefully pass on this one now |
Signed-off-by: Keith Zantow <[email protected]>
kzantow
force-pushed
the
fix-duplicated-constraint
branch
from
b3a3442 to
713a1c1
Compare
willmurphyscode
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
Thanks @jneate for the contribution! And sorry for the long delay in reviewing.
willmurphyscode
pushed a commit
that referenced
this pull request
Mar 27, 2024
Bumps [pytest-xdist](https://github.com/pytest-dev/pytest-xdist) from 3.2.0 to 3.2.1. - [Release notes](https://github.com/pytest-dev/pytest-xdist/releases) - [Changelog](https://github.com/pytest-dev/pytest-xdist/blob/master/CHANGELOG.rst) - [Commits](pytest-dev/pytest-xdist@v3.2.0...v3.2.1) --- updated-dependencies: - dependency-name: pytest-xdist dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the constraint is being reduced to a single column regardless of the CPE source, it makes sense to remove the duplicated constraints before storing in the DB.
I think this could resolve anchore/grype#1235