fix: redact passwords under account-routes #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobmel
force-pushed
the
bmelander/ENTERPRISE-4159-Passwords-under-account-routes-are-not-redacted-in-logs
branch
4 times, most recently
from
1c94d42 to
ddc2a38
Compare
bradleyjones
approved these changes
Jul 9, 2024
This commit makes changes so that all passwords and private keys are redacted in logs, when json marshalled and when yaml marshalled. It also fixes so that config keys have correct names (e.g. include '-' for multi-word keys)) when marhalled to yaml and json. Finally, it fixes so that the 'default' key/value pairs under metadata-collection(.nodes|.namespaces|.pods) are properly unmarshalled. Addresses: ENTERPRISE-4159 Signed-off-by: Bob Melander <[email protected]>
bobmel
force-pushed
the
bmelander/ENTERPRISE-4159-Passwords-under-account-routes-are-not-redacted-in-logs
branch
from
ddc2a38 to
0b7d3f8
Compare
bobmel
deleted the
bmelander/ENTERPRISE-4159-Passwords-under-account-routes-are-not-redacted-in-logs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes changes so that all passwords and private keys are redacted in logs, when json marshalled and when yaml marshalled.
Addresses: ENTERPRISE-4159