Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure missing config errors are caught #273

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

bradleyjones
Copy link
Member

@bradleyjones bradleyjones commented Sep 12, 2024

Error returns from reading the config were being ignored so if the config file doesn't exist we just proceeded with using the default config.

See Issue #269 for more context.

Signed-off-by: Bradley Jones [email protected]

@bradleyjones bradleyjones requested a review from a team as a code owner September 12, 2024 22:14
Copy link
Contributor

@bobmel bobmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bradleyjones bradleyjones merged commit 391eff1 into main Sep 13, 2024
4 checks passed
@bradleyjones bradleyjones deleted the issue-269 branch September 13, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants