Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consul binary classifier #1590

Closed
noqcks opened this issue Feb 18, 2023 · 1 comment · Fixed by #1738
Closed

consul binary classifier #1590

noqcks opened this issue Feb 18, 2023 · 1 comment · Fixed by #1738
Labels
enhancement New feature or request good-first-issue Good for newcomers

Comments

@noqcks
Copy link
Contributor

noqcks commented Feb 18, 2023

What would you like to be added:

A binary classifier for consul

Why is this needed:

consul is widely used and is usually not installed with a package manager inside docker images

pullCount : 500M+
starCount : 1.4K+
from https://hub.docker.com/_/consul

Additional context:

current ouput from syft 0.72.0

$ syft -q  packages library/consul | grep consul

github.com/hashicorp/consul                         v0.0.0-20230126154710-dae670fefdb5     go-module
github.com/hashicorp/consul-awsauth                 v0.0.0-20220713182709-05ac1c5c2706     go-module
github.com/hashicorp/consul-net-rpc                 v0.0.0-20220307172752-3602954411b4     go-module

cpe used should be

cpe:2.3:a:hashicorp:consul:*:*:*:*:*:*:*:*
@noqcks noqcks added the enhancement New feature or request label Feb 18, 2023
@tgerla tgerla added this to OSS Feb 23, 2023
@tgerla tgerla added the good-first-issue Good for newcomers label Feb 23, 2023
@tgerla tgerla moved this to Backlog in OSS Feb 23, 2023
@tgerla
Copy link
Contributor

tgerla commented Feb 23, 2023

Hi @noqcks, great suggestion, we'll add this to the backlog and tag it "good first issue" in case you or anyone else wants to jump in and add this--it's pretty easy.

shanedell added a commit to shanedell/syft that referenced this issue Apr 14, 2023
@shanedell
Create consul binary classifier
5466705 
Closes anchore#1590

Signed-off-by: Shane Dell <[email protected]>
@shanedell shanedell mentioned this issue Apr 14, 2023
Merged
wagoodman pushed a commit that referenced this issue Apr 17, 2023
@shanedell
Create consul binary classifier (#1738)
244b797 
* Create consul binary classifier

Closes #1590

Signed-off-by: Shane Dell <[email protected]>

* Create test for consul binary classifier

Signed-off-by: Shane Dell <[email protected]>

* Update version for consul. Add note that about consul version matcher is brittle

Signed-off-by: Shane Dell <[email protected]>

---------

Signed-off-by: Shane Dell <[email protected]>
@github-project-automation github-project-automation bot moved this from Backlog to Done in OSS Apr 17, 2023
This was referenced Apr 18, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
This was referenced May 8, 2023
Closed
Merged
Closed
Closed
GijsCalis pushed a commit to GijsCalis/syft that referenced this issue Feb 19, 2024
@shanedell
Create consul binary classifier (anchore#1738)
40f4a15 
* Create consul binary classifier

Closes anchore#1590

Signed-off-by: Shane Dell <[email protected]>

* Create test for consul binary classifier

Signed-off-by: Shane Dell <[email protected]>

* Update version for consul. Add note that about consul version matcher is brittle

Signed-off-by: Shane Dell <[email protected]>

---------

Signed-off-by: Shane Dell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good-first-issue Good for newcomers
Projects
OSS
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create consul binary classifier shanedell/syft
2 participants
@tgerla @noqcks