Add a setup.py cataloger
#150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alfredo Deza <[email protected]>
wagoodman
reviewed
Aug 17, 2020
| // integrity check | ||
| var _ common.ParserFn = parseSetup | ||
|
|
||
| var pinnedDependency = regexp.MustCompile(`['"]\W?(\w+\W?==\W?[\w\.]*)`) |
There was a problem hiding this comment.
nit: would be useful to add a few example matches in comments to illustrate to devs what this is trying to match on (similar to
syft/syft/cataloger/java/archive_filename.go
Lines 13 to 16 in ac9141e
There was a problem hiding this comment.
Great suggestion, I'll add those
There was a problem hiding this comment.
This is now improved!
wagoodman
reviewed
Aug 17, 2020
| // integrity check | ||
| var _ common.ParserFn = parseSetup | ||
|
|
||
| var pinnedDependency = regexp.MustCompile(`['"]\W?(\w+\W?==\W?[\w\.]*)`) |
There was a problem hiding this comment.
nit: there is an opportunity to be more lenient with spaces and capture more environment marker cases with ['"]\s*([\w]+\s*==\s*[\w\.]*)\s*[;'"] which would find ipaddress==1.0 in:
setup(
...
install_requires=[
'six',
'humanize',
],
extras_require={
':python_version == "2.7"': [
'ipaddress==1.0',
],
},
)
Not necessary to incorporate in this PR.
added 2 commits
August 17, 2020 16:00
Signed-off-by: Alfredo Deza <[email protected]>
Signed-off-by: Alfredo Deza <[email protected]>
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
Add a `setup.py` cataloger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will go into
setup.pyfiles, but only capture dependencies that are pinned (using the==operator).Closes #59