java: fix wrong filename-based guessed archive version #2144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fragile filename Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
hainenber
force-pushed
the
fix-wrong-filename-based-guess-java-archive-version
branch
from
4fc4238 to
18ac744
Compare
|
Convert to draft as the changes in this commit breaks a lot of existing assumption |
|
Closing this as I wasn't able to halt parsing filename of nested JAR files to fix the RC; there were too many breakges |
hainenber
deleted the
fix-wrong-filename-based-guess-java-archive-version
branch
|
@hainenber thanks for making the attempt! If you'd like to work with one of the maintainers on getting this unstuck, feel free to let us know on slack or at our community meeting / office hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2130
Also switch
slicesusage to standard library's instead of relying togolang/x/exp/slices