Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set cataloger names within package cataloger task #3165

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

wagoodman
Copy link
Contributor

ELF packages do not have the found-by field set:

❯ syft localhost/elf-test -o json | jq '.artifacts[] | select(.name == "alex")'
{
  "id": "a428c7d43ccc1e36",
  "name": "alex",
  "version": "v1.2.3",
  "type": "deb",
  "foundBy": "",
  ...
  "purl": "pkg:deb/[email protected]",
  "metadataType": "elf-binary-package-note-json-payload",
  "metadata": {
    "type": "deb"
  }
}

This PR fixes this behavior to always include the cataloger name.

@wagoodman wagoodman added the bug Something isn't working label Aug 27, 2024
@wagoodman wagoodman force-pushed the set-empty-cataloger-names branch from be9b166 to 8f36473 Compare August 27, 2024 13:07
@wagoodman wagoodman requested a review from a team August 27, 2024 13:07
@wagoodman wagoodman merged commit 4ee6c17 into main Aug 27, 2024
11 checks passed
@wagoodman wagoodman deleted the set-empty-cataloger-names branch August 27, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants