Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add pull request template #3294

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Conversation

willmurphyscode
Copy link
Contributor

@willmurphyscode willmurphyscode commented Oct 3, 2024

Description

Add a pull request template so that it's more obvious what we hope to see in pull requests.

Type of change

  • documentation

Checklist:

all n/a (no code change)

  • I have added unit tests that cover changed behavior
  • I have tested my code in common scenarios and confirmed there are no regressions
  • I have added comments to my code, particularly in hard-to-understand sections

Copy link
Contributor

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 we can always iterate on this later, but this looks like a good start to me

@willmurphyscode willmurphyscode self-assigned this Oct 5, 2024
@willmurphyscode willmurphyscode merged commit 0d45714 into main Oct 5, 2024
12 checks passed
@willmurphyscode willmurphyscode deleted the chore-add-pr-template branch October 5, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants