Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(reproducibility): add buildid= and trimpath #847

Closed
wants to merge 1 commit into from

Conversation

developer-guy
Copy link
Contributor

Signed-off-by: Batuhan Apaydın [email protected]

@developer-guy
Copy link
Contributor Author

cc: @wagoodman

@developer-guy developer-guy force-pushed the feature/repro branch 7 times, most recently from 6221f17 to 1c84e85 Compare February 24, 2022 15:10
@wagoodman
Copy link
Contributor

The trimpath and buildid changes look great 👍 , but same question as anchore/grype#642 (comment) , why change GOPATH here?

Copy link
Contributor

@wagoodman wagoodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@developer-guy developer-guy force-pushed the feature/repro branch 2 times, most recently from f5a9b53 to 375d73b Compare February 25, 2022 06:19
@developer-guy
Copy link
Contributor Author

seems everything is fine @wagoodman, thanks a ton 🙋🏻‍♂️

spiffcs
spiffcs previously approved these changes Jul 11, 2022
@spiffcs spiffcs self-requested a review July 11, 2022 14:12
@spiffcs spiffcs dismissed their stale review July 11, 2022 14:12

got context from previous review on grype

@wagoodman
Copy link
Contributor

I'm going to mark this as stale, but feel free to open up a new issue if you wanted to talk about this further!

@wagoodman wagoodman closed this Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants