Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requires-python metadata #28

Merged

Conversation

matthewfeickert
Copy link
Contributor

  • Add requires-python metadata through the addition of setuptools's python_requires in setup.py.

  • The addition of requires-python is to provide guards to keep older CPython versions from installing releases that could contain unrunnable code.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* Add requires-python metadata through the addition of setuptools's
  python_requires in setup.py.
   - c.f. https://peps.python.org/pep-0621/#requires-python

* The addition of requires-python is to provide guards to keep older
  CPython versions from installing releases that could contain
  unrunnable code.
@matthewfeickert
Copy link
Contributor Author

@andhus this is ready for review. Please let me know if you have any questions.

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4842a71) to head (aa3d4fb).

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #28   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          194       192    -2     
  Branches        34        34           
=========================================
- Hits           194       192    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@andhus andhus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for the delay.

@andhus andhus merged commit 26be94e into andhus:master Jun 20, 2024
8 checks passed
@matthewfeickert matthewfeickert deleted the build/add-requires-python-metadata branch June 20, 2024 19:38
@matthewfeickert
Copy link
Contributor Author

Thanks @andhus! Would you be willing to make patch releases of scantree and dirhash with these in?

@andhus
Copy link
Owner

andhus commented Jun 21, 2024

Thanks @andhus! Would you be willing to make patch releases of scantree and dirhash with these in?

Done ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants