Skip to content

Commit

Permalink
fixed typos, fix microsoft#2374
Browse files Browse the repository at this point in the history
  • Loading branch information
@andikrueger
andikrueger committed Oct 11, 2022
1 parent 6aba341 commit 87735be
Show file tree
Hide file tree
Showing 2 changed files with 36 additions and 31 deletions.
60 changes: 31 additions & 29 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,35 +16,37 @@
* Initial Release
* TeamsUserCallingSettings
* InitialRelease
* MISC
* Fixed an issue in in Export-M365DSCConfiguration when used with Service Principal

# 1.22.1005.1

* AADUser
* Renamed from O365User
* Added support for Roles.
FIXES [#2288](https://github.com/microsoft/Microsoft365DSC/issues/2288)
FIXES [#2288](https://github.com/microsoft/Microsoft365DSC/issues/2288)
* AADGroup
* Added properties MemberOf and AssignedToRole
Implements [#2301](https://github.com/microsoft/Microsoft365DSC/issues/2301)
Implements [#2301](https://github.com/microsoft/Microsoft365DSC/issues/2301)
* AADTenantDetails
* Fixed an issue where ApplicationSecret was send to Update-MgOrganization
* FIXES [[#2340](https://github.com/microsoft/Microsoft365DSC/issues/2340)]
* FIXES [[#2340](https://github.com/microsoft/Microsoft365DSC/issues/2340)]
* EXOATPPolicyForO365
* [BREAKING] Removed the deprecated BlockURLs, AllowClickThrough, EnableSafeLinksForO365Clients and TrackClicks parameters.
* EXOMailContact
* Initial Release.
* EXOMailTips
* Fixes an issue where MailTips weren't extracted when using CertificateThumbprint to authenticate.
FIXES [#2235](https://github.com/microsoft/Microsoft365DSC/issues/2235)
FIXES [#2235](https://github.com/microsoft/Microsoft365DSC/issues/2235)
* O365User
* [BREAKING] Resource was renamed to AADUser.
FIXES [#2204](https://github.com/microsoft/Microsoft365DSC/issues/2204)
FIXES [#2204](https://github.com/microsoft/Microsoft365DSC/issues/2204)
* IntuneDeviceConfigurationPolicyiOS
* [Breaking] Changed all the MediaContentRating properties to be CIMInstances.
FIXES [#1871](https://github.com/microsoft/Microsoft365DSC/issues/1871)
FIXES [#1871](https://github.com/microsoft/Microsoft365DSC/issues/1871)
* SCSensitivityLabel
[BREAKING] Changed Setting attribute in MSFT_SCLabelLocaleSettings to LabelSetting since its resevered word and breaking reporting.
FIXES #2314
FIXES #2314
* MISC
* [BREAKING] Authentication property ApplicationSecret has been changed across all resources to be of type
PSCredential instead of string. This will ensure that the secrets get encrypted in MOF files
Expand Down Expand Up @@ -102,7 +104,7 @@
and TeamsChannelLocationException properties were not properly set on Update.
FIXES #2173
* SCRetentionComplianceRule
* Fixes an issue when trying to create new compliancerule for Teams based policies where invalid
* Fixes an issue when trying to create new compliance rule for Teams based policies where invalid
parameters were passed.
FIXES #2181
* DEPENDENCIES
Expand All @@ -118,7 +120,7 @@
* Ignore precanned filters if recipient filter is used. Precanned filters and recipient filter cannot be used at the same time.
FIXES [#2194](https://github.com/microsoft/Microsoft365DSC/issues/2194)
* EXOSafeLinksPolicy
* Add Suport for EnableSafeLinksForEmail and DisableUrlRewrite
* Add Support for EnableSafeLinksForEmail and DisableUrlRewrite
* EXOInboundConnector
* Add support for different syntax of SenderDomains parameter
FIXES [#2180](https://github.com/microsoft/Microsoft365DSC/issues/2180)
Expand Down Expand Up @@ -318,17 +320,17 @@
* EXOSafeLinksPolicy
* Deprecated properties DoNotAllowClickThrough, DoNotTrackUserClicks & IsEnabled.
* IntuneAppProtectionPolicyiOS
* Fixed issue with creation a new policies where it was complaining about invalid minimum versions.
* Fixed issues where creating new policies threw an error complaining about an invalid duration format.
* Fixed issue with creation a new policies where it was complaining about invalid minimum versions.
* Fixed issues where creating new policies threw an error complaining about an invalid duration format.
FIXES [#2019](https://github.com/microsoft/Microsoft365DSC/issues/2019)
* Added the CustomBrowserProtocol paramters.
* Added the CustomBrowserProtocol parameters.
FIXES [#2009](https://github.com/microsoft/Microsoft365DSC/issues/2009)
* IntuneDeviceAndAppManagementAssignmentFilter
* Initial release.
* SCComplianceTag
* Fixed issue where FilePlanProperty was not properly applied unless another child property was also modified.
* SPOSharingSettings
* Updated code to remove None as valid value for DefaultLinkPermission. If value is set to None default to Edit.
* Updated code to remove None as valid value for DefaultLinkPermission. If value is set to None default to Edit.
* DEPENDENCIES
* Updated Microsoft.PowerApps.Administration.PowerShell to version 2.0.150.
* Updated MSCloudLoginAssistant to version 1.0.87.
Expand Down Expand Up @@ -370,7 +372,7 @@
# 1.22.622.1

* TeamsMessagingPolicy
* Removed the -force deprecated parameter on New/Set/Remove
* Removed the -force deprecated parameter on New/Set/Remove
* MISC
* Modified the dependency installation functions to for the AllUsers scope.

Expand Down Expand Up @@ -414,7 +416,7 @@
* IntuneASRRulesPolicyWindows10
* Initial release;
* PPowerAppsEnvironment
* Fixed issue on export to exclude EnvironmenTypes of Notspecified and Developer
* Fixed issue on export to exclude EnvironmentTypes of Notspecified and Developer
* Updated validation set of EnvironmentTypes to latest values
* DEPENDENCIES
* Updated MSCloudLoginAssistant module to version 1.0.84.
Expand Down Expand Up @@ -445,7 +447,7 @@
# 1.22.511.1

* AADNamedLocationPolicy
* Added error handling in the Get-TargetResource function.
* Added error handling in the Get-TargetResource function.
* EXOIRMConfiguration
* Initial release.
* EXOMessageClassification
Expand Down Expand Up @@ -837,7 +839,7 @@ MISC

# 1.21.1013.1

* Obfuscating Authentication Secrets from the Verbose output;
* Obfuscating Authentication Secrets from the Verbose output;

# 1.21.1006.3

Expand Down Expand Up @@ -945,7 +947,7 @@ MISC
# 1.21.804.1

* SCDLPComplianceRule
* Fixed issue where SCDLPCompliance rule failed when using senstitivy labels;
* Fixed issue where SCDLPCompliance rule failed when using sensitivity labels;
* DEPENDENCIES;
* Updated MSCloudLoginAssistant to version 1.0.62;
* MISC
Expand Down Expand Up @@ -1061,7 +1063,7 @@ MISC

# 1.21.526.2

* EXOSafeAttachmentRule
* EXOSafeAttachmentRule
* Fixed issue #1213 Policy X already has rule Y associated with it
if rule exists already
* MSFT_IntuneDeviceCompliancePolicyAndroid
Expand Down Expand Up @@ -1091,7 +1093,7 @@ MISC
* Forces a Global load of the new MicrosoftTeams module for
Teams resources;

#1.21.519.1
# 1.21.519.1

* TeamsClientConfiguration
* Fixed an issue where the RestrictedSenderList was not properly
Expand All @@ -1102,7 +1104,7 @@ MISC

# 1.21.512.1

* EXOOfflineAddresBook
* EXOOfflineAddressBook
* Fixed issue in Set-TargetResource where ConfiguredAttributes
was passed and resulted in an error.
* SCDLPComplianceRule
Expand All @@ -1114,7 +1116,7 @@ MISC
* EXOTransportRule
* Adding ExceptIfSCLOver and SCLOver.
* Fixes SubjectOrBodyContainsWords parameter not being an array.
* Fixes DateTime formating on ExpiryDate and ActivationDate
* Fixes DateTime formatting on ExpiryDate and ActivationDate

# 1.21.428.2

Expand Down Expand Up @@ -1205,7 +1207,7 @@ MISC
* SPOSiteDesign
* Added support for GrouplessTeamSite web template.
* SPOSiteScript
* Fixed issue where an existin site script could not be updated.
* Fixed issue where an existing site script could not be updated.
* Made parameter GlobalAdminAccount in Get-TargetResource
optional.
* SPOTheme
Expand Down Expand Up @@ -1350,7 +1352,7 @@ MISC
* TeamsMeetingPolicy
* Added 'OrganizerOnly' as a support value for property
AutoAdmittedUsers.
* Temporarly removed the use of AllowAnonymousUsersToDialOut
* Temporarily removed the use of AllowAnonymousUsersToDialOut
since it is currently disabled on the API side.
* EXPORT
* Fixed an issue where an Export using the -Workloads
Expand Down Expand Up @@ -1624,7 +1626,7 @@ MISC
specified;
* MISC
* Added a new Assert-M365DSCBlueprint function to generate
discrepency report between export of tenant and a BluePrint;
discrepancy report between export of tenant and a BluePrint;
* Metadata
* Updated DSCParser Module to version 1.2.0.0;
* Updated Microsoft.Graph.Authentication Module to version
Expand Down Expand Up @@ -1691,7 +1693,7 @@ MISC

* AADApplication
* Fix an issue where a new AzureAD Application was not created
if ObjectId was speficied;
if ObjectId was specified;
* O365User
* Fixed an issue where the PasswordNeverExpires value returned
was incorrect;
Expand Down Expand Up @@ -1843,10 +1845,10 @@ MISC
* SPOPropertyBag
* Fixed an issue where false positive drifts were being detected;
* SPOSiteAuditSettings
* Generalized the URL not to capture hardcoded dmomains;
* Generalized the URL not to capture hardcoded domains;
* SPOSiteGroup
* Fixed an issue where now, groups with Null owners are not extracted;
* Generalized the URL not to capture hardcoded dmomains;
* Generalized the URL not to capture hardcoded domains;
* TeamsCallingPolicy
* Removed the AllowCalling parameter since it is no longer supported;
* Fixed an issue with Policies without tags in their name (e.g. Global);
Expand Down Expand Up @@ -1878,7 +1880,7 @@ MISC
* TeamsGuestMessagingConfiguration
* Added value NoRestriction for GiphyRatingValues;
* Metadata
* Removed dependencyon MSOnline;
* Removed dependency on MSOnline;
* Updated MSCloudLoginAssistant dependency to 1.0.2;
* Updated SharePointPnPPowerShellOnline dependency to 3.18.2002.0;
* Updated Microsoft.PowerApps.Administration.PowerShell
Expand Down
7 changes: 5 additions & 2 deletions Modules/Microsoft365DSC/Modules/M365DSCReverse.psm1
View file
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,10 @@ function Start-M365DSCConfigurationExtract
$AuthMethods -contains 'ApplicationWithSecret')
{
$organization = Get-M365DSCTenantDomain -ApplicationId $ApplicationId `
-TenantId $TenantId
-TenantId $TenantId `
-CertificateThumbprint $CertificateThumbprint `
-ApplicationSecret $ApplicationSecret `
-CertificatePath $CertificatePath
}
elseif ($AuthMethods -Contains 'Credentials')
{
Expand All @@ -253,7 +256,7 @@ function Start-M365DSCConfigurationExtract
$AzureAutomation = $false
if ($organization.IndexOf('.') -gt 0)
{
$principal = $organization.Split('.')[0]
$organization = $organization.Split('.')[0]
}

[array] $version = Get-Module 'Microsoft365DSC'
Expand Down

0 comments on commit 87735be

Please sign in to comment.