Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify user if the SHELL environment variable is unset. #155

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/CPAN/FirstTime.pm
Original file line number Diff line number Diff line change
Expand Up @@ -1057,6 +1057,9 @@ sub init {
$path ||= 'sh', $path =~ s,\\,/,g if $^O eq 'os2'; # Cosmetic only
my_dflt_prompt(shell => $path, $matcher);
}
if (!$CPAN::Config->{shell}) {
$CPAN::Frontend->mywarn("No user shell found. Please set the SHELL environment variable\n");
}
}

{
Expand Down Expand Up @@ -1496,6 +1499,9 @@ HERE
);

sub _find_shell_config {
if (!$CPAN::Config->{shell}) {
$CPAN::Frontend->mydie("No user shell found. Please set the SHELL environment variable");
}
my $shell = File::Basename::basename($CPAN::Config->{shell});
if ( my $rc = $shell_rc_map{$shell} ) {
my $path = File::Spec->catfile($ENV{HOME}, $rc);
Expand Down