Feat is never #115
Open
Feat is never #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to @krisdages for finding this! This commit removes the `string` condition on `IsNever` because `keyof never === keyof any === string`. Closes: #109
The tests for this were purely focused around the string form. This commit adds more complete tests to account for the wider range of applicability. This commit also simplifies the conditional of the original form.
The new `IsNever` only works with 3.5, so all older versions need to be dropped. This will bump the major version of `simplytyped` to avoid any breaking changes. I think it is worth it to drop older versions of the language to keep this package from rotting too severely, as long as we are careful with updating the major version whenever we change the supported TS versions. BREAKING CHANGE: no longer supporting typescript < 3.5
Retsam
reviewed
Jul 22, 2019
| @@ -15,7 +15,7 @@ export type ObjectPrototypeKeys = keyof Object; | |||
| /** no-doc */ | |||
| export type FunctionPrototypeKeys = keyof Function; | |||
|
|
|||
| export type IsNever<S extends string> = Not<(Record<S, True> & Record<string, False>)[S]>; | |||
| export type IsNever<T> = keyof any extends keyof T ? Not<IsAny<T>> : False; | |||
There was a problem hiding this comment.
It's weird to me that keyof never is the same as keyof any, while keyof unknown is never. This feels like the sort of thing that might break in a later version of TS, but I suppose that's what the tests are for...
Retsam
approved these changes
Jul 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.