complying with specifications.freedesktop.org about a default value for XDG_CONFIG_HOME #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thank you for pointing it out about specification and the wrong order of checking for config. Could you kindly format your commit messages according to this (rebase and combine two commits) and capitalize your comment. Thank you for your contribution! |
|
the comment starts with a name of a variable (default_dir), are you sure it should be capitalized? (and thus not reflect the actual name of the variable) |
|
Yes, it shouldn't. I first didn't notice, than noticed, but forgot 😅 |
- Apply freedesktop.org's specification regarding XDG_CONFIG_HOME in both the installation script and the final executable. - Look for the config file in the default directory first.
andreykaere
added a commit
that referenced
this pull request
Dec 2, 2023
It was overwritten accidentally, when merging `complete_refactor` to `dev`
andreykaere
added a commit
that referenced
this pull request
Dec 2, 2023
It was overwritten accidentally, when merging `complete_refactor` to `dev`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to freedesktop.org's specifications: "If $XDG_CONFIG_HOME is either not set or empty, a default equal to $HOME/.config should be used.".
this pull request would apply that specification.
also, the existing implementation of
src/config.rslooks for the configuration file in the default directory before a specific (user defined) directory. I don't believe this was intentional. because having a default value for XDG_CONFIG_HOME would cause the code that looks for the configuration file in the specific directory to be unreachable, this pull request makes it so that the configuration is looked for in the specific directory, before the default one (and not after).