Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Where is api android-25 in folder 'platforms' in ndk r14b or r15b? #372

Closed
skanti opened this issue Apr 24, 2017 · 7 comments
Closed

Where is api android-25 in folder 'platforms' in ndk r14b or r15b? #372

skanti opened this issue Apr 24, 2017 · 7 comments
Assignees
@DanAlbert
Milestone
r16

Comments

@skanti
Copy link

skanti commented Apr 24, 2017

In the ndk folder in subfolder 'platforms' the api android-25 does not exist. Does it have a particular reason? In ndk r15b (beta) there is api android-24 and android-26 but not version 25.
@DanAlbert
Copy link
Member

There were no new native APIs in android-25.

@alexcohn
Copy link

alexcohn commented Jul 2, 2017 •
edited
Loading

@DanAlbert Well, we don't need platforms/android-25 folder; but setup-app-platform.mk must accept APP_PLATFORM=android-25 (or at least target=android-25 in project.properties), and step down to android-24, shouldn't it?

On r14 this was irrelevant, since android-24 was NDK_MAX_PLATFORM_LEVEL.

@DanAlbert
Copy link
Member

Why not just set APP_PLATFORM := android-24 instead? APP_PLATFORM := android-25 just cuts one more release unnecessarily off the bottom of your minSdkVersion.

... or is gradle sharing some target API variable between Java and the NDK, and using android-25 Java APIs forces this? It should really just be using minSdkVersion for the NDK target API, but idk if that's the case.

@alexcohn
Copy link

I don't know if the TS had this specific issue, but yes, if someone has minSdkVersion=25 in build.gradle, which is fully legitimate, then ndk-build will fail for NDK r15.

@DanAlbert
Copy link
Member

Yeah, okay, that makes sense. Reopening.

@DanAlbert DanAlbert reopened this Jul 11, 2017
@ehem ehem mentioned this issue Jul 27, 2017
Open
@DanAlbert DanAlbert removed the invalid label Aug 10, 2017
@DanAlbert
Copy link
Member

https://android-review.googlesource.com/c/455206

@DanAlbert DanAlbert added this to the r16 milestone Aug 10, 2017
@DanAlbert DanAlbert self-assigned this Aug 10, 2017
@DanAlbert
Copy link
Member

Merged into r16.

miodragdinic pushed a commit to MIPS/ndk that referenced this issue Apr 17, 2018
@DanAlbert
Fill in a gap in APP_PLATFORM.
0fe876e 
We didn't have any new native APIs for android-25, but it's still a
valid minSdkVersion, and so still a valid NDK target API.

Test: ./run_tests.py --filter no_platform_gaps --rebuild
Bug: android/ndk#372
Change-Id: Ifd5806807329082e20db20c84265756dcfd4ef4a
@podraco podraco mentioned this issue Sep 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanAlbert DanAlbert

Labels
None yet
Projects
None yet
Milestone
r16
Development

No branches or pull requests
3 participants
@DanAlbert @alexcohn @skanti