-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump JDK 17 and using toolchain #1392
Conversation
Thanks for your PR. Currently there are conflicts that need to be resolved before we can move on to possibly accepting your contribution. Please resolve the conflicts. |
Change-Id: I53d35fc503e4390bc6e2ac58504d359e7ddacffd
Change-Id: Ic59bea192e57190251592beb88fd31297f1671a4
b43e1c6
to
e11cac7
Compare
@keyboardsurfer Ready to merge. |
Hi! We've recently changed our direction on using toolchain for our samples. We still recommend it for developer projects, but we want to limit 3P Gradle plugins (in this case, the foojay resolver) that we use in samples. To that end, we want to keep The convention plugin has been updated to JDK 17, so I'll close this PR. |
@javadude I just have a question. In the libs.versions.toml, some sort of 3P Gradle plugins exist: |
Sure. We're considering maintenance over the longer term. Unfortunately, we don't have control over 3P plugins, so they can disappear at any time, they may lose maintainers and break when Gradle APIs change, or worse, be taken over by a malicious party. We're especially sensitive to Gradle plugins here, as they run on the system with all the rights of whatever user runs the build. If there's a reasonable alternative (in this case, sticking with the |
@javadude I understand your considers. If I find any official plugins, I will soon create new PR. |
Without a resolver, tool chain becomes painful if the exact JDK version isn't installed. |
What I have done and why
• Replace
sourceCompatibility
andtargetCompatibility
totoolchain
• Add toolchain resolver
org.gradle.toolchains.foojay-resolver-convention
• Bump JDK11 to JDK17
JDK 17
In this issuetracker shows, no need to fix the version of JDK at 11 to use desugaring.
https://issuetracker.google.com/issues/343505126
toolchain
According this documentation
resolver
documentation
Fix #1483
How I'm testing it
Choose at least one: