Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CameraXViewfinder from new camerax-compose artifact #107

Merged
merged 6 commits into from
Jan 19, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -131,10 +131,10 @@ dependencies {
implementation(libs.core.performance.play.services)

implementation(libs.camera.core)
implementation(libs.camera.compose)
implementation(libs.camera2)
implementation(libs.camera.lifecycle)
implementation(libs.camera.view)
implementation(libs.camera.viewfinder.compose)

implementation(libs.media3.common)
implementation(libs.media3.effect)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ fun Camera(
}

val viewFinderState by viewModel.viewFinderState.collectAsStateWithLifecycle()
val surfaceRequest by viewModel.surfaceRequest.collectAsStateWithLifecycle()
var rotation by remember { mutableStateOf(Surface.ROTATION_0) }

DisposableEffect(lifecycleOwner, context) {
Expand All @@ -123,40 +124,31 @@ fun Camera(

rotationProvider.addListener(Dispatchers.Main.asExecutor(), rotationListener)

viewModel.startPreview(lifecycleOwner, captureMode, cameraSelector, rotation)

onDispose {
rotationProvider.removeListener(rotationListener)
}
}

val onPreviewSurfaceProviderReady: (Preview.SurfaceProvider) -> Unit = {
surfaceProvider = it
viewModel.startPreview(lifecycleOwner, it, captureMode, cameraSelector, rotation)
}

fun setCaptureMode(mode: CaptureMode) {
captureMode = mode
surfaceProvider?.let { provider ->
viewModel.startPreview(
lifecycleOwner,
provider,
captureMode,
cameraSelector,
rotation,
)
}
viewModel.startPreview(
lifecycleOwner,
captureMode,
cameraSelector,
rotation,
)
}

fun setCameraSelector(selector: CameraSelector) {
cameraSelector = selector
surfaceProvider?.let { provider ->
viewModel.startPreview(
lifecycleOwner,
provider,
captureMode,
cameraSelector,
rotation,
)
}
viewModel.startPreview(
lifecycleOwner,
captureMode,
cameraSelector,
rotation,
)
}

@SuppressLint("MissingPermission")
Expand Down Expand Up @@ -246,7 +238,7 @@ fun Camera(
) {
ViewFinder(
viewFinderState.cameraState,
onPreviewSurfaceProviderReady,
surfaceRequest,
viewModel::setZoomScale,
)
}
Expand All @@ -259,7 +251,7 @@ fun Camera(
) {
ViewFinder(
viewFinderState.cameraState,
onPreviewSurfaceProviderReady,
surfaceRequest,
viewModel::setZoomScale,
)
}
Expand Down Expand Up @@ -308,7 +300,11 @@ fun Camera(
}

@Composable
fun CameraControls(captureMode: CaptureMode, onPhotoButtonClick: () -> Unit, onVideoButtonClick: () -> Unit) {
fun CameraControls(
captureMode: CaptureMode,
onPhotoButtonClick: () -> Unit,
onVideoButtonClick: () -> Unit,
) {
val activeButtonColor =
ButtonDefaults.buttonColors(containerColor = MaterialTheme.colorScheme.primary)
val inactiveButtonColor =
Expand All @@ -332,7 +328,12 @@ fun CameraControls(captureMode: CaptureMode, onPhotoButtonClick: () -> Unit, onV
}

@Composable
fun ShutterButton(captureMode: CaptureMode, onPhotoCapture: () -> Unit, onVideoRecordingStart: () -> Unit, onVideoRecordingFinish: () -> Unit) {
fun ShutterButton(
captureMode: CaptureMode,
onPhotoCapture: () -> Unit,
onVideoRecordingStart: () -> Unit,
onVideoRecordingFinish: () -> Unit,
) {
Box(modifier = Modifier.padding(25.dp, 0.dp)) {
if (captureMode == CaptureMode.PHOTO) {
Button(
Expand Down Expand Up @@ -367,15 +368,21 @@ fun ShutterButton(captureMode: CaptureMode, onPhotoCapture: () -> Unit, onVideoR
}

@Composable
fun CameraSwitcher(captureMode: CaptureMode, cameraSelector: CameraSelector, setCameraSelector: KFunction1<CameraSelector, Unit>) {
fun CameraSwitcher(
captureMode: CaptureMode,
cameraSelector: CameraSelector,
setCameraSelector: KFunction1<CameraSelector, Unit>,
) {
if (captureMode != CaptureMode.VIDEO_RECORDING) {
IconButton(onClick = {
if (cameraSelector == CameraSelector.DEFAULT_BACK_CAMERA) {
setCameraSelector(CameraSelector.DEFAULT_FRONT_CAMERA)
} else {
setCameraSelector(CameraSelector.DEFAULT_BACK_CAMERA)
}
}) {
IconButton(
onClick = {
if (cameraSelector == CameraSelector.DEFAULT_BACK_CAMERA) {
setCameraSelector(CameraSelector.DEFAULT_FRONT_CAMERA)
} else {
setCameraSelector(CameraSelector.DEFAULT_BACK_CAMERA)
}
},
) {
Icon(
imageVector = Icons.Default.Autorenew,
contentDescription = null,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ import androidx.camera.core.FocusMeteringAction
import androidx.camera.core.ImageCapture
import androidx.camera.core.ImageCaptureException
import androidx.camera.core.Preview
import androidx.camera.core.SurfaceRequest
import androidx.camera.core.UseCaseGroup
import androidx.camera.core.resolutionselector.AspectRatioStrategy
import androidx.camera.core.resolutionselector.ResolutionSelector
Expand All @@ -60,6 +61,8 @@ import java.text.SimpleDateFormat
import java.util.Locale
import javax.inject.Inject
import kotlinx.coroutines.flow.MutableStateFlow
import kotlinx.coroutines.flow.StateFlow
import kotlinx.coroutines.flow.update
import kotlinx.coroutines.launch

private const val TAG = "CameraViewModel"
Expand All @@ -84,9 +87,16 @@ class CameraViewModel @Inject constructor(
.setAspectRatioStrategy(aspectRatioStrategy)
.build()

private val _surfaceRequest = MutableStateFlow<SurfaceRequest?>(null)
val surfaceRequest: StateFlow<SurfaceRequest?> = _surfaceRequest

private val previewUseCase = Preview.Builder()
.setResolutionSelector(resolutionSelector)
.build()
.build().apply {
setSurfaceProvider { newSurfaceRequest ->
_surfaceRequest.update { newSurfaceRequest }
}
}

private val imageCaptureUseCase = ImageCapture.Builder()
.setResolutionSelector(resolutionSelector)
Expand Down Expand Up @@ -141,7 +151,6 @@ class CameraViewModel @Inject constructor(

fun startPreview(
lifecycleOwner: LifecycleOwner,
surfaceProvider: Preview.SurfaceProvider,
captureMode: CaptureMode,
cameraSelector: CameraSelector,
rotation: Int,
Expand All @@ -156,9 +165,7 @@ class CameraViewModel @Inject constructor(
}
var extensionsCameraSelector: CameraSelector? = null
val useCaseGroupBuilder = UseCaseGroup.Builder()

previewUseCase.setSurfaceProvider(surfaceProvider)
useCaseGroupBuilder.addUseCase(previewUseCase)
.addUseCase(previewUseCase)

if (captureMode == CaptureMode.PHOTO) {
try {
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,9 @@

package com.google.android.samples.socialite.ui.camera

import androidx.camera.core.Preview
import androidx.camera.viewfinder.surface.ImplementationMode
import androidx.camera.compose.CameraXViewfinder
import androidx.camera.core.SurfaceRequest
import androidx.camera.viewfinder.core.ImplementationMode
import androidx.compose.foundation.background
import androidx.compose.foundation.gestures.rememberTransformableState
import androidx.compose.foundation.gestures.transformable
Expand All @@ -31,7 +32,7 @@ import androidx.compose.ui.graphics.Color
@Composable
fun ViewFinder(
cameraState: CameraState,
onSurfaceProviderReady: (Preview.SurfaceProvider) -> Unit = {},
surfaceRequest: SurfaceRequest?,
onZoomChange: (Float) -> Unit,
) {
val transformableState = rememberTransformableState(
Expand All @@ -49,11 +50,13 @@ fun ViewFinder(
modifier = Modifier
.transformable(state = transformableState),
) {
CameraXViewfinder(
modifier = Modifier.fillMaxSize(),
implementationMode = ImplementationMode.PERFORMANCE,
onSurfaceProviderReady = onSurfaceProviderReady,
)
surfaceRequest?.let {
CameraXViewfinder(
modifier = Modifier.fillMaxSize(),
implementationMode = ImplementationMode.EXTERNAL,
surfaceRequest = surfaceRequest,
)
}
}
}
}
2 changes: 1 addition & 1 deletion baselineprofile/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ plugins {

android {
namespace = "com.google.android.samples.socialite.baselineprofile"
compileSdk = 34
compileSdk = 35

compileOptions {
sourceCompatibility = JavaVersion.VERSION_1_8
Expand Down
Loading
Loading