Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UA spoof stops working after Temp permission #53

Closed
LeeUK opened this issue Jun 22, 2016 · 4 comments
Closed

UA spoof stops working after Temp permission #53

LeeUK opened this issue Jun 22, 2016 · 4 comments
Assignees

Comments

@LeeUK
Copy link

LeeUK commented Jun 22, 2016

Hi,

The UA Spoof works fine when JS is otherwise 'disabled' by ScriptSafe. As soon as Temp permissions are granted however, the spoofing seems to stop. I'm unsure if this is by design, or a bug? If by design, perhaps an option to continue the spoof even after deciding to grant permission for JS to run on a given site could be implemented?

Awesome plugin. One of my absolute favourite "must-haves". Thank you.

@andryou andryou self-assigned this Jun 22, 2016
@andryou
Copy link
Owner

andryou commented Jun 22, 2016

Excellent suggestion. Yes that is expected behaviour (because one example is it interferes with Gmail), but I will add in a checkbox labelled "Apply to allowed sites as well"!

andryou added a commit that referenced this issue Jun 22, 2016
… options, consolidate fingerprinting code

Address #52 and #53, bumped version no. and added beta label for beta
testing.
@andryou
Copy link
Owner

andryou commented Jun 22, 2016

Beta version now available which addresses this :) See: #54

@LeeUK
Copy link
Author

LeeUK commented Jun 23, 2016

Sorry for the late reply. Bravo sir, bravo!

I see your (very valid) point about the reasons behind turning it off after JS is allowed. Those of us who fiddle with that bit will probably appreciate the option for it to persist though; and we can always nuke it if it continues to cause issues. :)

@andryou
Copy link
Owner

andryou commented Jun 30, 2016

@LeeUK I've just officially pushed out v1.0.8.0, which contains this fix. Feel free to test it out when it arrives on your machine and close this ticket :)

@andryou andryou closed this as completed Dec 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants