Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth: add disable disconnect on expiry config #204

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

andydunstall
Copy link
Owner

Adds support for disabling disconnecting the client when their JWT expires.

See #179 (comment).

cc @dipack95

Adds support for disabling disconnecting the client when their JWT
expires.
Copy link
Contributor

@dipack95 dipack95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you!

@andydunstall andydunstall merged commit 8e376a8 into main Dec 15, 2024
3 checks passed
@andydunstall andydunstall deleted the add-disconnect-on-expiry branch December 15, 2024 12:29
@dipack95
Copy link
Contributor

@andydunstall Can I trouble you for a version release that includes this change? Excited to give this a shot!

@andydunstall
Copy link
Owner Author

How are you running Piko? You can create the Docker images manually with make image or build the binary with make piko?

(I can tag later this week though it's probably quicker for you to build yourself)

@dipack95
Copy link
Contributor

I've been downloading the docker image from gcr.io, and the binaries from the releases page since these are being deployed on EKS. I can wait for a new tag though, thank you!

@andydunstall
Copy link
Owner Author

@dipack95 thats tagged, sorry for the delay https://github.com/andydunstall/piko/releases/tag/v0.6.5

@dipack95
Copy link
Contributor

@andydunstall Thank you so much! This project is really appreciated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants