Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 0 as load address for Mach-O libraries #436

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

fmagin
Copy link
Contributor

@fmagin fmagin commented Nov 8, 2023

No description provided.

@rhelmot
Copy link
Member

rhelmot commented Nov 8, 2023

There seem to be three testcase failures - one spurious and two which assert that the thing you changed has not change. fix these testcases and I shall merge at your command!

@fmagin fmagin force-pushed the fmagin/fix_macho_load_address branch from 1cf2698 to 2acde60 Compare November 9, 2023 08:18
@fmagin fmagin force-pushed the fmagin/fix_macho_load_address branch from 2acde60 to 89414f6 Compare November 9, 2023 08:20
@fmagin
Copy link
Contributor Author

fmagin commented Nov 9, 2023

The Mach-O tests for the old base address are now fixed.

By now I also understand what was going on that required the workaround of loading at 0: There is an entire blob with rebase bytecode that isn't parsed yet, that should have fixed up some pointers. I'll be working on that in the next few days, and then Mach-O apps and libraries should have proper rebasing support

@rhelmot rhelmot merged commit a496989 into angr:master Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants