You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 29, 2019. It is now read-only.
I ran into an issue if you have multiple modal, the backdrop somehow will be messed up.
Since the var backdropEl;is shared across the directives, only one backdrop element will be inserted to body.
Therefore if you open a second modal before closing the first one and close it, the screen will have no backdrop when the first modal remains open.
I think there are two ways to fix this.
Movevar backdrop into link function, so every modal has its own backdrop.
Having a counter across the directives for keeping track how many modal is opened.
And elm.parent().append(backdropEl); instead of body.append(backdropEl);
in case the modal is inside of a template, when you load template, the a new backdrop will be appended to body.
The text was updated successfully, but these errors were encountered:
I don't know, we should be probably stacking up modals if multiple of them are open. But while doing so we should refactor both the modal directive and the $dialog service to have the logic dealing with backdrops in one place.
I ran into an issue if you have multiple modal, the backdrop somehow will be messed up.
Since the
var backdropEl;
is shared across the directives, only one backdrop element will be inserted to body.Therefore if you open a second modal before closing the first one and close it, the screen will have no backdrop when the first modal remains open.
I think there are two ways to fix this.
var backdrop
into link function, so every modal has its own backdrop.And
elm.parent().append(backdropEl);
instead ofbody.append(backdropEl);
in case the modal is inside of a template, when you load template, the a new backdrop will be appended to body.
The text was updated successfully, but these errors were encountered: