$dialog service: Separate messageBox into its own service

[petebacondarwin]

@typesafe & @pkozlowski-opensource & @SidhNor

Although it is rather useful to have message box functionality easily available, I think it would be cleaner to separate it out into its own service that happens to rely on $dialog. Then the API would be easier to use. Also, if you didn't need the message box service, you wouldn't need to include its module or its template.

Instead of:

var myDialog = $dialog.dialog({ ... some options ... });
myDialog.open();

and

var myMessageBox = $dialog.messageBox(title, message, buttons);
myMessageBox.open();

You could have $dialog and $messageBox services:

var myDialog = $dialog({... some options ...});
myDialog.open();

and

var myMessageBox = $messageBox(title, message, buttons);
myMessageBox.open();

[pkozlowski-opensource]

@petebacondarwin +1 if you ask me.

Those $dialog and $messageBox services are really awesome but we need to do slightly better in terms of API (which is normal for the version 0.1.0). @petebacondarwin pushes it in the right direction IMO.

This issue should be considered alongside #170 which also touches dialog's API.

[SidhNor]

+1
I'll take that if you don't mind. :)
Do you think we should provide resolves to messageBox.open() as well?

[petebacondarwin]

+1 resolves to message box as it should be easy to pass them through to the
underlying dialog box and you don't know who might need them?

On 28 February 2013 14:27, Gleb Godonoga [email protected] wrote:

+1
I'll take that if you don't mind. :)
Do you think we should provide resolves to messageBox.open() as well?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/175#issuecomment-14235511
.

[pkozlowski-opensource]

Will be handled in #441