Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Modal backdrop css in class not being removed when closing modal #2674

Closed
pswai opened this issue Sep 8, 2014 · 1 comment
Closed

Modal backdrop css in class not being removed when closing modal #2674

pswai opened this issue Sep 8, 2014 · 1 comment

Comments

@pswai
Copy link

pswai commented Sep 8, 2014

UI Bootstrap 0.11.0
Twitter Bootstrap 3.1.1
AngularJS >= 1.2.16

Plunker http://plnkr.co/edit/iBCTFEVTT44O769bMIEL?p=preview

When closing modal, the animation of modal backdrop is not working before it is removed from DOM. The in css class is not removed by ngClass even though scope.animate is already false.

This issue happens only with AngularJS >= 1.2.16.

@chrisirhc
Copy link
Contributor

Will be fixed via #2724

chrisirhc added a commit to chrisirhc/angular-ui-bootstrap that referenced this issue Oct 20, 2014
- Fix scope.$apply call not working previously because scope was already
  destroyed. Use $rootScope instead.
- Move $destroy call nearer to the dom removal.
- Remove fallback timer (emulateTime param)

Fixes angular-ui#2585
Fixes angular-ui#2674
Fixes angular-ui#2536
Fixes angular-ui#2790
chrisirhc added a commit to chrisirhc/angular-ui-bootstrap that referenced this issue Mar 19, 2015
- Fix scope.$apply call not working previously because scope was already
  destroyed. Use $rootScope instead.
- Move $destroy call nearer to the dom removal.
- Remove fallback timer (emulateTime param)

Fixes angular-ui#2585
Fixes angular-ui#2674
Fixes angular-ui#2536
Fixes angular-ui#2790
Fixes angular-ui#3182
chrisirhc added a commit to chrisirhc/angular-ui-bootstrap that referenced this issue Mar 23, 2015
- Fix scope.$apply call not working previously because scope was already
  destroyed. Use $rootScope instead.
- Move $destroy call nearer to the dom removal.
- Remove fallback timer (emulateTime param)

Fixes angular-ui#2585
Fixes angular-ui#2674
Fixes angular-ui#2536
Fixes angular-ui#2790
Fixes angular-ui#3182
Closes angular-ui#2724
@karianna karianna added this to the 0.13.0 milestone Mar 23, 2015
ayakovlevgh pushed a commit to ayakovlevgh/bootstrap that referenced this issue Mar 24, 2015
- Fix scope.$apply call not working previously because scope was already
  destroyed. Use $rootScope instead.
- Move $destroy call nearer to the dom removal.
- Remove fallback timer (emulateTime param)

Fixes angular-ui#2585
Fixes angular-ui#2674
Fixes angular-ui#2536
Fixes angular-ui#2790
Fixes angular-ui#3182
Closes angular-ui#2724
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants