Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

[Datepicker] Repeated months #3079

Closed
ayakovlevgh opened this issue Dec 10, 2014 · 3 comments
Closed

[Datepicker] Repeated months #3079

ayakovlevgh opened this issue Dec 10, 2014 · 3 comments
Labels
component: datepicker needs: info

Comments

@ayakovlevgh
Copy link
Contributor

There is an issue with repeated months in some years in Russian time zones (Moscow UTC +3, Novosibirsk UTC +6).
The issue occurrs only in Firefox (version 33.0, 34.0). In Google Chrome everything is OK.
Angular bootstrap version: 0.12.0.
Screenshots are attached.

datepicker2
datepicker1
@qinzitong
Copy link

The newest version of AngularJS Batarang did not parse the month html

ayakovlevgh added a commit to ayakovlevgh/bootstrap that referenced this issue Mar 24, 2015
@ayakovlevgh
fix(datepicker): time zone bug
adfe047 
The bug is hard-reproducible and dependent on OS, browser, current timezone and current date
  i.e.
    var date = new Date(2014, 0, 1);
    console.log(date.getFullYear(), date.getMonth(), date.getDate(), date.getHours());
  can result in "2013 11 31 23" because of the bug.

Fixes angular-ui#3079
ayakovlevgh added a commit to ayakovlevgh/bootstrap that referenced this issue Mar 24, 2015
@ayakovlevgh
fix(datepicker): time zone bug
decf2a7 
The bug is hard-reproducible. It depends on OS, browser, current timezone and current date.
  i.e.
    var date = new Date(2014, 0, 1);
    console.log(date.getFullYear(), date.getMonth(), date.getDate(), date.getHours());
  can result in "2013 11 31 23" because of the bug.

Fixes angular-ui#3079
@ayakovlevgh ayakovlevgh mentioned this issue Mar 25, 2015
Closed
@chrisirhc
Copy link
Contributor

Is this related to https://bugzilla.mozilla.org/show_bug.cgi?id=1079720 ?

@ayakovlevgh
Copy link
Contributor Author

Partially yes.
Actually, I could reproduce three cases of this problem:

  1. Win 7; GMT +3 /+6; current date = Dec 10, 2014.

    Problem with new Date(2014, 0, 1) and some other dates.

    This case is described in bugzilla's ticket you are referencing to.

  2. Win 7; GMT -3; current date doesn't matter.

    Problem with new Date(2016, 9, 16) and lots of other dates.

    Also described in a topic on stackoverflow

  3. Ubuntu / Debian; GMT +3/+6; current date doesn't matter.

    Problem with new Date(1984, 3, 1), new Date(2040, 3, 1) and some others.

I suppose there could be more cases. And I think even if Firefox developers fix it, there is no guarantee that such problem won't appear again in Firefox or other browsers.

ayakovlevgh added a commit to ayakovlevgh/bootstrap that referenced this issue Mar 27, 2015
@ayakovlevgh
fix(datepicker): time zone bug
c05e35d 
Explicitly check for 23.

Addresses: angular-ui#3079, angular-ui#3433
ayakovlevgh added a commit to ayakovlevgh/bootstrap that referenced this issue Mar 31, 2015
@ayakovlevgh
fix(datepicker): time zone bug
a013c66 
Micro-optimization.

Addresses: angular-ui#3079, angular-ui#3433
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: datepicker needs: info
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(datepicker): time zone bug ayakovlevgh/bootstrap
4 participants
@chrisirhc @karianna @qinzitong @ayakovlevgh