Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Setting active slide for carousel doesn't work with ngAnimate #4667

Closed
jholt1 opened this issue Oct 20, 2015 · 3 comments
Closed

Setting active slide for carousel doesn't work with ngAnimate #4667

jholt1 opened this issue Oct 20, 2015 · 3 comments

Comments

@jholt1
Copy link

jholt1 commented Oct 20, 2015

Angular, animate - v1.4.7
Bootstrap - v0.14.2

Not a new issue see: #2235

@jholt1
Copy link
Author

jholt1 commented Oct 20, 2015

http://plnkr.co/edit/OjmPa0FukOfqJ8JYlqo9?p=preview

You can see that when changing slides (first two buttons) that the carousel doesn't work. With active the slide shows up but you cannot change slides and without active everything disappears. Changing active on its own does work.

However if you remove ngAnimate in my plnkr everything works.

@wesleycho
Copy link
Contributor

There's one thing being done very wrong here - breaking the reference to the slides array is bad.

Forked the Plunker with those fixes here, but this needs a little looking into.

@wesleycho
Copy link
Contributor

This should now be fixed in master, as can be seen here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants