ngAnimate regression in 1.4 & 1.5

[wesleycho]

We have an interesting regression from 1.3 to 1.4 & 1.5 with ngAnimate in UI Bootstrap - here is a Plunker, and the issue is angular-ui/bootstrap#4667 .

It should be noted that it works perfectly fine in 1.3, but both branches of the relevant code in the Plunker copy of the carousel code (lines 50-61 in ui-bootstrap.js) never seem to run the event handler callbacks.

[matsko]

Could you provide more info as to what's going on? It seems broken all together.

[wesleycho]

I'm not sure what is happening in the internals of ngAnimate here, but this is the problem block we are coming across in UI Bootstrap

      if (NEW_ANIMATE) {
        $animate.on('addClass', slide.$element, function(element, phase) {
          if (phase === 'close') {
            $scope.$currentTransition = null;
            $animate.off('addClass', element);
          }
        });
      } else {
        slide.$element.one('$animate:close', function closeFn() {
          $scope.$currentTransition = null;
        });
      }

The event handlers are never getting called in either when tweaking the block.

[Narretz]

That's still broken on master.
What I would like is a smaller demo with clear repro steps. It's a bit problematic since the slider seems erratic.

[wesleycho]

Sorry, looks like this was a false alarm - I made an incorrect change it looks like, fixing it makes this work properly again as seen here.

[Narretz]

@wesleycho Great to hear!