If a location change triggers a dialog to display the dialog is visible for a moment then closed

[mattcole]

This seems to be caused by the handleLocationChange function which calls the close() method when a location change occurs. Effectively this close method ends up running after the dialog has been opened in the new location, closing it immediately.

I've resolved this by adding a check to see if the dialog is opened before closing it:

if(self._open) self.close();

but due to the $dialog rewrite issue am not sure whether it's worth submitting a pull request or just raising it as an issue that needs resolving.

[maxisam]

Ah ha ! I found this issue too ! Almost at the same time with you. I think it is still worth to mention. Anyway, my solution is pretty much like yours. I add if(!self._open) return false; in close method.

[pkozlowski-opensource]

@mattcole @maxisam I'm currently rewriting $dialog, will handle this issue in #441

[maxisam]

Awesome ! Thank you for your great effort !

[mattcole]

Brilliant, thanks :)