Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Tabs: Add selected tab index to the onDeselect parameters #5820

Closed
ksieburg opened this issue Apr 19, 2016 · 0 comments
Closed

Tabs: Add selected tab index to the onDeselect parameters #5820

ksieburg opened this issue Apr 19, 2016 · 0 comments
Labels
component: tab type: enhancement

Comments

@ksieburg
Copy link
Contributor

ksieburg commented Apr 19, 2016 •
edited
Loading

When a tab is selected and the deselect function calls preventDefault() on the event, it is sometimes desirable to be able to navigate to the tab that was attempted to be opened after some work has been performed. One example is when you show a confirmation dialog that asks the user if they wish to save their changes before continuing. Without the selected tab index being passed, after the user makes his selection there is no way to determine which tab he should be taken to.

This plunker demonstrates the issue (change the text in the first tab's text box)

And this one demonstrates the fix

I will be submitting a PR for this shortly.

Angular: 1.5.3

UIBS: 1.3.2
ksieburg added a commit to ksieburg/bootstrap that referenced this issue Apr 19, 2016
@ksieburg
feat(tabs): pass the selected tab index to onDeselect
e675ea1 
-  Add the index of the tab the user attempted to open to the onDeselect call, which allows the user to directed to the selected tab
after some work is performed.

- Closes angular-ui#5820
This was referenced Apr 19, 2016
Merged
Closed
ksieburg added a commit to ksieburg/bootstrap that referenced this issue Apr 19, 2016
@ksieburg
feat(tabs): pass the selected tab index to onDeselect
1b54f02 
- Doc update

- Fixes angular-ui#5820
ksieburg added a commit to ksieburg/bootstrap that referenced this issue Apr 19, 2016
@ksieburg
feat(tabs): pass the selected tab index to onDeselect
1fca691 
-  Add the index of the tab the user attempted to open to the onDeselect call, which allows the user to directed to the selected tab
after some work is performed.

- Closes angular-ui#5820
ksieburg added a commit to ksieburg/bootstrap that referenced this issue Apr 19, 2016
@ksieburg
feat(tabs): pass the selected tab index to onDeselect
ef58dd3 
-  Add the index of the tab the user attempted to open to the onDeselect call, which allows the user to directed to the selected tab
after some work is performed.

- Closes angular-ui#5820
ksieburg added a commit to ksieburg/bootstrap that referenced this issue Apr 19, 2016
@ksieburg
feat(tabs): pass the selected tab index to onDeselect
8a3a833 
-  Add the index of the tab the user attempted to open to the onDeselect call, which allows the user to directed to the selected tab
after some work is performed.

- Closes angular-ui#5820
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: tab type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wesleycho @ksieburg