Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

chore(modal): Remove unused code #143

Closed
wants to merge 1 commit into from
Closed

chore(modal): Remove unused code #143

wants to merge 1 commit into from

Conversation

wallin
Copy link

@wallin wallin commented Feb 15, 2013

Just went through the modal code and noticed that there was an unused function. Not sure if it was left there intentionally for later use or just a leftover from the past

Just went through the modal code and noticed that there was an unused function. Not sure if it was left there intentionally for later use or just a leftover from the past
@pkozlowski-opensource
Copy link
Member

@wallin Thnx so much for spotting this one, good catch! In fact we are in the process of refactoring (or more harmonizing) implementation of the modal and the $dialog service - you can see WIP in https://github.com/angular-ui/bootstrap/tree/refact/dialogmodal and more discussion in #128

So in the very near feature this unnecessary code will go away. Going to close this PR as getting it in would mean more difficult merge of the refactoring branch, but once again, thnx for looking into this and taking time opening this PR.

@wallin
Copy link
Author

wallin commented Feb 16, 2013

Sure! No problem. Keep up the good work!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants