This repository has been archived by the owner on May 29, 2019. It is now read-only.
refactor(demos): use angular modules #1912
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Foxandxss LGTM although I would use a more consistent module name, like |
|
Sure, I put what was already there (the plunks we generate use that module name, so I took it). I'll fix that 👍 |
|
@bekos Done ;) |
|
@Foxandxss was about to merge this one but realised that it doesn't merge cleanly anymore... Would you mind rebasing it? Thnx! |
|
That should be it @pkozlowski-opensource |
|
Merged, thnx! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old demos works good, but creating controllers that way is not the recommended way, not even for demos. So I modified all of them to use proper angular modules. I think that the result is now better (before we had two different types of conventions for controllers and now we have just one and better one).
I also modified the plunker generator to use the same module as the demo page (so the demos won't break up on plunker).
This closes #1884