Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Datepicker improvements #2911

Closed
wants to merge 2 commits into from
Closed

Conversation

mmouterde
Copy link

  • A datepicker is about 200 bindings. On a page with many datepickers (20 in my use case) this amount of bindings has a real impact on performance.
    • I suggest to add a boolean lazyDom parameter to datepickerPopupConfig. When this parameter is true, the datepicker popup Dom and bindings are created on focus and deleted on blur.
  • The datepicker popup root element (UL) has no attribute or class to allow jquery/angular.element selection
    • I suggest to add a 'datepicker-popup' class to this UL element

…w parameter 'lazyDom' is added to datepickerPopupConfig.

Set this parameter to true make the datepicker DOM removed on blur, created on focus.
Unless this identifier, there is no clean way to select the datepicker popup UL using jquery  (or angular.element) selectors.
@ilanbiala
Copy link

This seems like a good idea, though a collab should review it to make sure that the logic works out.

@chrisirhc
Copy link
Contributor

Thank you, but #1915 is a more complete version of this improvement. Please review and test the logic there instead.

@chrisirhc chrisirhc closed this Nov 5, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants