This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(dateparser): Throws on invalid date format string. #3691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 20, 2015
|
Please add one feature per PR. Based on your PR description, this PR adds two:
Am I correct? |
Closed
|
Can you please rebase this on top of current |
stevecavanagh
force-pushed
the
fix(dateParser)ThrowsOnInvalidFormat
branch
from
3a2db43 to
f2ab8fb
Compare
|
Rebased as requested. Thanks. |
|
Sorry, can you rebase again? Lot of changes happened since then :( . |
Test unparsable date string is undefined.
stevecavanagh
force-pushed
the
fix(dateParser)ThrowsOnInvalidFormat
branch
from
f2ab8fb to
24fe82e
Compare
|
Lots of changes = lots of good stuff coming into this project. :) Rebased. |
|
Thinking about this, I'm not sure whether it makes sense to throw by default - this should probably be configurable. In addition, this needs to be rebased again (sorry! Some big features & fixes have landed since then) |
|
Going to close due to staleness - feel free to open a new PR based on current |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #3568. The dateParser will throw an exception for an invalid format string. In addition to fixing some code formatting issues, this PR also handles parsing dates from the datepicker with a datetime-local type.