This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(carousel): ensure there are slides present #3788
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure there are slides present before calling `$scope.next` in timer
|
You can safely ignore the Travis error here - I mistakenly pushed to origin, and so I deleted that branch before Travis finished without realizing that it would affect this PR. |
|
LGTM |
|
Doh, forgot to put closes #3788 in my cherry-picking. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$scope.nextin timerThere is a possible situation where the carousel errors when the slide count is dynamically changed to 0.
This fixes #3755.
Plunker of fix in action here.