Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Fixing reference to Dialog's backdrop element so it closes properly #381

Closed
wants to merge 1 commit into from

Conversation

sbosell
Copy link

@sbosell sbosell commented May 1, 2013

Relates to #379

There should only be one backdrop element, so the service now will hold a reference to this backdrop element so that it can be properly removed.

There should only be one backdrop element, so the service now will hold a reference to this backdrop element so that it can be properly removed.
@pkozlowski-opensource
Copy link
Member

@sbosell thnx for this PR but the current $dialog code is kind of broken from the design point of view and I'm in process of rewriting it right now in scope of #441

Prefer to focus on rewrites instead of patching broken code. Thnx for your work and heads up though!

@i8ramin
Copy link

i8ramin commented Jun 21, 2013

Not sure if this is related, but somehow I was getting negative values for activeBackdrops.value when navigating through my app. Adding this bit of logic around line 224 inside the _removeElementsFromDom method fixed the problem for me. Looking forward to the rewrite.

if (activeBackdrops.value > 0) {
  activeBackdrops.value--;
}

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants